FFT 125: Scrollable tables across FFT #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Dudley <[email protected]>
Co-authored-by: Sam Dudley <[email protected]>
- [ ] JIRA ticket referenced in title - [ ] Title is clear and concise - [ ] Description gives any relevant detail - [ ] Tests are up to date - [ ] Documentation is up to date
Remove EditPayroll component and substitue PayrollTable component as it was an unneeded abstraction Add key to RowComponent to remove unique key warning - [ ] JIRA ticket referenced in title - [ ] Title is clear and concise - [ ] Description gives any relevant detail - [ ] Tests are up to date - [ ] Documentation is up to date
|
This PR introduces a couple of magic numbers into the CSS. Let's have a discussion offline and see if there is a solution that avoids magic numbers. |
SamDudley
force-pushed
the
sprint-48
branch
2 times, most recently
from
2e62ef1 to
5601c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all tables scrollable and prevent them trailing off of the page
Updated tables (all that I am aware of):
//