Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Fix warnings #567

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Tech debt: Fix warnings #567

merged 3 commits into from
Dec 6, 2024

Conversation

CaitBarnard
Copy link
Contributor

@CaitBarnard CaitBarnard commented Dec 6, 2024

Removed download_permissions.py for end of month as the file name clashed with an existing templatetags file and the code is no longer in use. has_end_of_month_archive_permission had been replaced by has_end_of_month_archive_permissions

Renamed report url as the colon caused an ambiguous name reference warning

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

@CaitBarnard CaitBarnard marked this pull request as ready for review December 6, 2024 16:02
@CaitBarnard CaitBarnard requested a review from a team as a code owner December 6, 2024 16:02
@CaitBarnard CaitBarnard merged commit f6390eb into main Dec 6, 2024
4 checks passed
@CaitBarnard CaitBarnard deleted the tebt-debt/fix-warnings branch December 6, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants