Feature/resolve celery #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized application package structure to improve modularity and navigability. Moved files from `fbr` to `app` directory and renamed key modules to better reflect functionality, such as `celery_worker`. Additionally, updated all relevant imports and settings configurations to align with the new structure, including Django settings and task management.
Reorganized application package structure to improve modularity and navigability. Moved files from `fbr` to `app` directory and renamed key modules to better reflect functionality, such as `celery_worker`. Additionally, updated all relevant imports and settings configurations to align with the new structure, including Django settings and task management.
Moved Dockerfile and entry script out of local_deployment for a cleaner structure. Updated docker-compose and Makefile to reflect these changes, using a unified image to leverage caching. Removed Poetry setup in favor of using pip with requirements.txt for dependency management.
Introduce DATABASE_URL environment variable for local PostgreSQL setup in Docker and Makefile. Update `rebuild_cache` task with a specific name and adjust its schedule. Refactor Django settings and Makefile commands for improved database management consistency.
The schedule for the cache rebuild task was incorrectly documented as running at a different time than configured. This change aligns both the actual schedule and the comment to correctly indicate the task runs at 1:00 AM daily.
Introduce a new make target to allow local setup with forced cache rebuild. This ensures that the local environment is set up and caches are manually rebuilt without relying on Celery tasks.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return Response(response, status=status.HTTP_200_OK) | ||
| except Exception as e: | ||
| return Response( | ||
| data={"message": f"error building csv download response: {e}"}, |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Unified the manage.py path by removing 'fbr/' prefix in scripts and configuration files, ensuring consistency across the project. Adjusted DJANGO_SETTINGS_MODULE in image_build_run.sh for a streamlined setup. These changes improve maintainability and reduce potential errors related to incorrect file paths.
Modify import paths for `create_search_query` and `SearchQuery` in `test_search.py` to reflect the correct module structure under `app/search/utils/search.py`. This ensures that test cases reference the correct location and maintain consistency with the application structure.
Updated the path to `manage.py` in the `collectstatic` command within the code quality GitHub workflow to correct the file path. This ensures the command executes successfully without errors related to incorrect paths.
Correct the syntax for the collectstatic command by explicitly using python with manage.py. This ensures compatibility and prevents potential execution issues in the CI environment.
Add handling for failed URL fetches by logging errors and storing them in a list instead of raising exceptions. This ensures that the process can continue attempting to build the cache while logging a comprehensive list of any failed sources.
Shortening the timeout improves the speed of clearing all documents and building the cache. This adjustment aims to enhance the system's responsiveness and efficiency during cache management operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.