refactor: Enhance Search Functionality and Security #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised `create_search_query` to handle AND/OR logic better and prevent SQL injection risks. Enhanced tests to validate query safety, adding coverage for edge cases. Updated dependencies to include improved security and functionality for library versions.
Refactored the search logic to enhance clarity and maintainability, introducing better query object handling and sanitization steps. Added `sanitize_all_if_needed` to prevent redundant sanitization and refactored config logging for consistency. Updated tests to reflect the new sanitization logic and adjusted sorting and logging for improved readability.
Simplified the query formation logic and improved code readability. Replaced precise ID matching and full-text query generation with a more coherent approach. Adjusted sort logic to ensure relevance-based sorting is descending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of the pull request