LTD: Remove unsupported HmrcQuery type related code #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saruniitr
force-pushed
the
LTD-remove-unsupported-hmrcquery
branch
from
8823fae to
750093c
Compare
|
Excellent, 100s lines over 25+ files removed, great stuff. |
We don't support this yet. The current implementation may not be relevant if we need to support it and can be added based on the requirement at that time.
saruniitr
force-pushed
the
LTD-remove-unsupported-hmrcquery
branch
from
750093c to
a2d30dd
Compare
|
What are your thoughts on removing the |
Was thinking of removing the models at the end in a separate PR (to reduce migrations). |
kevincarrogan
approved these changes
Feb 6, 2024
hnryjmes
approved these changes
Feb 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1802 +/- ##
==========================================
+ Coverage 87.17% 89.89% +2.71%
==========================================
Files 320 318 -2
Lines 17764 17660 -104
Branches 2263 2247 -16
==========================================
+ Hits 15486 15875 +389
+ Misses 1729 1285 -444
+ Partials 549 500 -49 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
We don't support
HmrcQueryyet. The current implementation may not be relevant if we need to support it and can be added based on the requirement at that time.