[LTD-5739] Ensure MOD-DI advice is shown at consolidation regardless of MOD-ECJU advice #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currycoder
force-pushed
the
LTD-5739-ensure-mod-di-advice-always-consolidated
branch
from
bad15f5 to
b556830
Compare
currycoder
force-pushed
the
LTD-5739-ensure-mod-di-advice-always-consolidated
branch
from
b556830 to
bd7ffa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
Colin summarises the issue brilliantly here; https://teams.microsoft.com/l/message/19:[email protected]/1734095933610?tenantId=8fa217ec-33aa-46fb-ad96-dfe68006bb86&groupId=eced0ad8-d420-418b-9e1a-1b3e26b68c46&parentMessageId=1734095933610&teamName=LITE%20DDaT%20Team&channelName=Licence%20conditions%20and%20DESNZ%20countersigning&createdTime=1734095933610
TLDR; We were "rolling up" advice from all MOD teams in to MOD-ECJU's advice at the point of LU consolidation if there was advice present from MOD-ECJU on the case.
The issue with this is that advice from MOD-DI is only consolidated by LU if it visited MOD-DI's "Indirect" queue. MOD-DI direct advice would effectively be masked away incorrectly. This could mean the potential for LU missing important licence conditions added by MOD-DI direct.
This change adjusts the advice that is surfaced at consolidation, such that MOD-DI's advice is always surfaced to LU. This may mean - in the case where a licence condition was added by MOD-DI indirect - that we show an additional licence condition that has already been combined by MOD-ECJU. However, it has been agreed that this is probably better than the alternative of potentially missing licence conditions raised by MOD-DI Direct.
LTD-5739