LTD-4652-send-email-task

[seijihg]

https://uktrade.atlassian.net/browse/LTD-4652

I have replaced smtp_send with celery task send_smtp_task which is being globally locked. I think this can be expanded in the future quite easily in memcache_lock if we add counter into the cache and just lock True when is counter == n

[stuaxo]

I know we called it celery_tasks, but tasks.py is the standard - probably too late to change this throughout, but there we go.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6a3be4) 85.76% compared to head (f2ca1f7) 85.89%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   85.76%   85.89%   +0.13%     
==========================================
  Files          46       46              
  Lines        2929     2957      +28     
  Branches      413      415       +2     
==========================================
+ Hits         2512     2540      +28     
  Misses        328      328              
  Partials       89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[saruniitr]

I have not looked at the tests as they will be very different once it is updated.
I can take a look again when ready.

We need to have tests that ensure child task is spawned and calls email sending methods.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6a3be4) 85.76% compared to head (c3b2e67) 85.82%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   85.76%   85.82%   +0.06%     
==========================================
  Files          46       46              
  Lines        2929     2963      +34     
  Branches      413      417       +4     
==========================================
+ Hits         2512     2543      +31     
- Misses        328      331       +3     
  Partials       89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.