Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTD-5128 Python3.9 upgrade #257

Merged
merged 2 commits into from
Jun 24, 2024
Merged

LTD-5128 Python3.9 upgrade #257

merged 2 commits into from
Jun 24, 2024

Conversation

markj0hnst0n
Copy link
Contributor

@markj0hnst0n markj0hnst0n commented Jun 20, 2024

Python3.9 upgrade and add typing-extensions package to ensure compatibility.

This has been deployed on the uat environment and tested manually. Results below.

Manual test case scenarios carried out using resend_edi_data_email.py management command:

  • EDI data email sent from Spire and ingested by Lite HMRC system with correct db information (PASS)
  • EDI data email sent on from Lite HMRC on to HMRC mailbox (PASS)
  • LITE API call simulated and Email sent from Lite HMRC to HMRC mailbox (PASS)

Other manual testing:

  • Health check viewed (PASS)
  • Checked mailbox connections with mail/management/commands/check_mailserver_connections.py managment command (PASS)

@markj0hnst0n markj0hnst0n marked this pull request as ready for review June 20, 2024 11:57
@depsiatwal
Copy link
Contributor

depsiatwal commented Jun 21, 2024

Has this been deployed any where ?
also @saruniitr or @currycoder any suggestions on testing this ?
similar to when we shifted to celery

@markj0hnst0n
Copy link
Contributor Author

markj0hnst0n commented Jun 21, 2024

it's been deployed on UAT for a while @depsiatwal I've run some the mailbox check management commands and checked the healthcheck

@saruniitr
Copy link
Contributor

Has this been deployed any where ? also @saruniitr or @currycoder any suggestions on testing this ? similar to when we shifted to celery

@markj0hnst0n @depsiatwal With celery all tasks were affected so tested all of them on UAT.
All of the testing is manual, there are test mailboxes attached to environments so we can use them to send licence data and reply messages as well.

@seijihg
Copy link
Contributor

seijihg commented Jun 21, 2024

hehe if this just happened earlier :D had some stuffs earlier where I needed 3.9 instead of making a work around because we were on 3.8 xD

Copy link
Contributor

@hnryjmes hnryjmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with Arun's comment, if you can use the mailboxes we have for use with the UAT environment and simulate some licence mails that should be a good test of the version upgrade. but I think I don't know quite how to do that myself (!)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (e17e70c) to head (fa9433e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          47       47           
  Lines        3039     3039           
  Branches      420      420           
=======================================
  Hits         2617     2617           
  Misses        334      334           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevincarrogan kevincarrogan merged commit 3d7ede4 into master Jun 24, 2024
5 checks passed
@kevincarrogan kevincarrogan deleted the upgrade-to-python3.9 branch June 24, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants