-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTD-5128 Python3.9 upgrade #257
Conversation
Has this been deployed any where ? |
it's been deployed on UAT for a while @depsiatwal I've run some the mailbox check management commands and checked the healthcheck |
@markj0hnst0n @depsiatwal With celery all tasks were affected so tested all of them on UAT. |
hehe if this just happened earlier :D had some stuffs earlier where I needed 3.9 instead of making a work around because we were on 3.8 xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with Arun's comment, if you can use the mailboxes we have for use with the UAT environment and simulate some licence mails that should be a good test of the version upgrade. but I think I don't know quite how to do that myself (!)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 47 47
Lines 3039 3039
Branches 420 420
=======================================
Hits 2617 2617
Misses 334 334
Partials 88 88 ☔ View full report in Codecov by Sentry. |
Python3.9 upgrade and add typing-extensions package to ensure compatibility.
This has been deployed on the uat environment and tested manually. Results below.
Manual test case scenarios carried out using
resend_edi_data_email.py
management command:Other manual testing:
mail/management/commands/check_mailserver_connections.py
managment command (PASS)