Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff unused import check to pre-commit and CI #258

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

hnryjmes
Copy link
Contributor

@hnryjmes hnryjmes commented Jun 21, 2024

Adds the ruff unused import check to pre-commit and CI following the pattern established in lite-frontend, lite-api, lite-routing.

@hnryjmes hnryjmes force-pushed the add_ruff_unused_import_check_20240621 branch from 6ee7984 to bd196bd Compare June 21, 2024 13:07
@hnryjmes hnryjmes force-pushed the add_ruff_unused_import_check_20240621 branch from bd196bd to 15ee665 Compare June 21, 2024 13:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@de7adcb). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage          ?   86.11%           
=========================================
  Files             ?       47           
  Lines             ?     3039           
  Branches          ?      420           
=========================================
  Hits              ?     2617           
  Misses            ?      334           
  Partials          ?       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hnryjmes hnryjmes force-pushed the add_ruff_unused_import_check_20240621 branch from f2520e4 to 06a962e Compare June 21, 2024 13:18
@hnryjmes hnryjmes force-pushed the add_ruff_unused_import_check_20240621 branch from 06a962e to 8706c8a Compare June 21, 2024 13:22
@hnryjmes hnryjmes marked this pull request as ready for review June 21, 2024 13:25
Copy link
Contributor

@depsiatwal depsiatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hnryjmes hnryjmes merged commit e17e70c into master Jun 21, 2024
5 checks passed
@hnryjmes hnryjmes deleted the add_ruff_unused_import_check_20240621 branch June 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants