Use custom code coverage checker #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincarrogan
force-pushed
the
LTD-5134-code-coverage
branch
4 times, most recently
from
65fcc5f to
d93eb8b
Compare
kevincarrogan
force-pushed
the
LTD-5134-code-coverage
branch
5 times, most recently
from
cb73990 to
e07fbeb
Compare
kevincarrogan
changed the title
markj0hnst0n
approved these changes
Jun 24, 2024
hnryjmes
reviewed
Jun 25, 2024
.circleci/config.yml
Outdated
| check_coverage: | ||
| working_directory: ~/lite-hmrc | ||
| docker: | ||
| - image: cimg/python:3.8.17 |
There was a problem hiding this comment.
is there a reason this has to be 3.8.17? I notice the other python images in the file and the python version in the Pipfile are at 3.8.18
There was a problem hiding this comment.
Copy and paste issue. Will update.
hnryjmes
approved these changes
Jun 25, 2024
kevincarrogan
force-pushed
the
LTD-5134-code-coverage
branch
from
e07fbeb to
75312b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes us using the external codecov tool, which for some reason was no longer working as expected, with the same toolset that we use on our other repos.