Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
insert_model
currently only hashes on the parent model’s hashes and nothing else, so you can’t have two different models that work on the same parents.It also runs with every
to_matchbox
call withResults
, and currently this means you can only do that once before it errors. Adding upserts functionality will fix.Changes proposed in this pull request
list_to_value_ordered_hash
ininsert_model
insert_model
to upsert when the hash is the sameGuidance to review
Relevant links
Checklist: