Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update admin script #15

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Fix/update admin script #15

merged 8 commits into from
Dec 2, 2024

Conversation

sophie-daintta
Copy link
Collaborator

Context

Changes proposed in this pull request

  • Update to the admin.py file
  • Backend update to "postgresql" from "postgres"
  • Update to dataset hashing in case of identical schemas

Checklist:

  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

wpfl-dbt
wpfl-dbt reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only objections are to those name changes for the backend enum and warehouse username. What broader problem are they solving? Why aren't I getting that problem -- would I be getting it if I were running the pipelines?

.github/workflows/pytest.yml Outdated Show resolved Hide resolved
sample.datasets.toml Outdated Show resolved Hide resolved
src/matchbox/admin.py Outdated Show resolved Hide resolved
wpfl-dbt
wpfl-dbt reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wpfl-dbt
wpfl-dbt approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (second try)

@sophie-daintta sophie-daintta merged commit ff499fd into main Dec 2, 2024
5 checks passed
@sophie-daintta sophie-daintta deleted the fix/update-admin-script branch December 2, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpfl-dbt wpfl-dbt wpfl-dbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophie-daintta @wpfl-dbt