-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added match function to the backend #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter, ahead of using this in match()
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the API endpoint is out of scope, but I'd like to see more tests
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 12, 2024
lmazz1-dbt
reviewed
Dec 13, 2024
lmazz1-dbt
reviewed
Dec 13, 2024
lmazz1-dbt
reviewed
Dec 13, 2024
lmazz1-dbt
reviewed
Dec 13, 2024
lmazz1-dbt
reviewed
Dec 13, 2024
Added |
lmazz1-dbt
reviewed
Dec 13, 2024
lmazz1-dbt
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Top of the features shopping list and vital for replicating the existing Company Matching endpoint using Matchbox is
match()
.Given an ID in a source dataset, it should return the paired keys from the target dataset from the perspective of a point of truth.
While there's plenty of edge cases and ways we might extend this, this is the vanilla implementation so we have something to work with.
Changes proposed in this pull request
match()
as a function throughout the library: client, server base class, PostgreSQL adapterClusters
andContains
to facilitate speed on this querybatch_ingest()
to permit use of indices via a newisolate_table
functionModels.get_lineage_to_dataset()
: the dataset model is now also returned, with accompanying change inquery()
logicGuidance to review
Focus on
matchbox.server.postgresql.utils.query
-- this is where the biggest, most confusing changes are.1:1
because my source data has no examples of this. I think this is okay for now -- do you agree?1:0
is now coveredstr | list[str] | None
because I think it's more elegantRelevant links
Checklist: