Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit and TruffleHog as mandatory requirements #18

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Add pre-commit and TruffleHog as mandatory requirements #18

merged 5 commits into from
Dec 5, 2024

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented Dec 3, 2024 •
edited
Loading

Context

Cyber have requested that the TruffleHog pre-commit hook is turned on. This adds it.

I've implemented this based on this article, the TruffleHog repo, and the TruffleHog sample precommit.

Changes proposed in this pull request

  • Adds TruffleHog as a pre-commit hook, plus dependencies
  • Adds just scan to scan the whole repo
  • Demands its use in the README

Guidance to review

  • Read changed

Relevant links

Checklist:

  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

lmazz1-dbt
lmazz1-dbt reviewed Dec 3, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Freshrojek
Freshrojek approved these changes Dec 5, 2024
View reviewed changes
Copy link

@Freshrojek Freshrojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Will, thanks for waiting for an approval.

lmazz1-dbt
lmazz1-dbt approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@lmazz1-dbt lmazz1-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wpfl-dbt wpfl-dbt merged commit f119ed0 into main Dec 5, 2024
5 checks passed
@wpfl-dbt wpfl-dbt deleted the feature/trufflehog-hook branch December 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazz1-dbt lmazz1-dbt lmazz1-dbt approved these changes

@Freshrojek Freshrojek Freshrojek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpfl-dbt @Freshrojek @lmazz1-dbt