-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to choose the columns we index on #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 9, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
reviewed
Dec 10, 2024
lmazz1-dbt
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Matchbox currently indexes every column. This makes it difficult to control how data is hashed, and is vulnerable to column renames or reorderings. Ticket. Feature shopping list.
Changes proposed in this pull request
datasets.toml
config file. You can configure:*
character as a shorthand for "select all"Source
object, ensuring private data isn't sent to the serverSources.alias
andSources.indices
to PostgreSQL backend, enabling reconstruction ofSource
by client if they have permission to access the tablequery
if a non-indexed column is selectedGuidance to review
Sources
, especially the datatype of the column indexes (JSONB
with base64-encoded hashes, as pure bytes isn't permitted)SourceColumn.type
isn't actually used anywhere yet -- the hashing algorithm casts everything to string anywayChecklist: