-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement first end-to-end client/server flow #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love matchbox.common.graph
. I've been thinking that we should describe the graph view that all backends represent views onto somewhere, because I think it's a useful conceptual introduction, and vital for anyone writing a backend. This is a great move in the direction of codifying the abstract model.
I trust you on VCR as a good solution for testing requests. I'm not going to look any further into it unless you think I should.
Why aren't you finishing the job with the Models*
table name purge?
I'm not wholly convinced by test.env
. It's also my experience that having sample.env
and test.env
be different is useful: sample.env
can showcase features, whereas test.env
has a job to do (see my sample one in the indexing branch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy based on our discussion that the full resolution rename happens in the next PR.
Context
Changes proposed in this pull request
_handler.py
which implements the interface for all client functions/methods to talk to the APItest.env
Guidance to review
_handler.py
after having looked into a few options, I'm using VCR cassettes. Essentially, only the first time a test is run, is the API actually hit, and the result stored in a fixture. If the API endpoint changes, the fixture needs to be manually deleted. Once we write more complex tests of this kind, we'll need to work out what happens when the client request changes, but I believe it will also try to hit the API again in that caseChecklist: