Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors the entire backend to rely on an adapter class #7

Merged
merged 29 commits into from
Oct 22, 2024

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented Oct 10, 2024

We're going to want to play with different backends. We therefore want to collect existing functionality into a single backend adapter that's used throughout the frontend via an injected client.

Warning

This PR has become unbelievably large. In this refactor I'm moving fast and breaking things (agreed by Leo) because I'm working alone, and because this is in service of making something that's easier to test and work with going forward. Much of what's shifting about here is going to get ripped out in the next PR.

Normally I'd turn this into a bunch of smaller PRs, I swear.

Changes proposed in this pull request

  • Created new backend abstract class
  • Created new PostgreSQL backend child of that class
  • Moved all existing logic into this new PostgreSQL class
  • Replaced all client-side functions with calls to this class

Guidance to review

  • Review the overall architectural arrangement of the new classes and confirm the API feels intuitive enough to extend
  • Confirm the unit tests pass. If the tests pass, the code is solid

Relevant links

Checklist:

  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

@wpfl-dbt wpfl-dbt marked this pull request as ready for review October 22, 2024 10:58
@wpfl-dbt wpfl-dbt merged commit c84a460 into main Oct 22, 2024
5 checks passed
@wpfl-dbt wpfl-dbt deleted the feature/adapter branch October 22, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant