Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DBTP-1678 maintenance page refactor #725

Merged
merged 12 commits into from
Jan 21, 2025

Conversation

a-gleeson
Copy link
Contributor

@a-gleeson a-gleeson commented Jan 15, 2025

Addresses DBTP-1678


What

The maintenance page still used patches so the domain level was refactored to inject dependencies.
The application gracefully exits when a user says no to confirm prompts
Slightly imporved coverage.
Tests moved from legacy enivornment command.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

  • Run the end to end tests for this branch and confirm that they are passing

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
643 3 640 3
View the top 3 failed tests by shortest run time
tests/platform_helper/domain/test_database_copy.py::test_copy_command[services1-default]
Stack Traces | 0.01s run time
.../platform_helper/domain/test_database_copy.py:377: in test_copy_command
    mocks.maintenance_page_provider.activate.assert_called_once_with(
.../hostedtoolcache/Python/3.10.16.../x64/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'activate' to be called once. Called 0 times.
tests/platform_helper/domain/test_database_copy.py::test_copy_command[services2-migrations]
Stack Traces | 0.01s run time
.../platform_helper/domain/test_database_copy.py:377: in test_copy_command
    mocks.maintenance_page_provider.activate.assert_called_once_with(
.../hostedtoolcache/Python/3.10.16.../x64/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'activate' to be called once. Called 0 times.
tests/platform_helper/domain/test_database_copy.py::test_copy_command[services0-default]
Stack Traces | 0.011s run time
.../platform_helper/domain/test_database_copy.py:377: in test_copy_command
    mocks.maintenance_page_provider.activate.assert_called_once_with(
.../hostedtoolcache/Python/3.10.16.../x64/lib/python3.10/unittest/mock.py:940: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'activate' to be called once. Called 0 times.

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@a-gleeson a-gleeson marked this pull request as ready for review January 17, 2025 10:28
@a-gleeson a-gleeson requested a review from a team as a code owner January 17, 2025 10:28
@a-gleeson a-gleeson merged commit a899bb3 into main Jan 21, 2025
10 checks passed
@a-gleeson a-gleeson deleted the DBTP-1678-maintenance-page-tests branch January 21, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants