feat: type annotations now allow strict type checking #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the internal tuple type to make the uncompressed size and crc_32 non optional ints which makes it possible to pass type checking without any ifs or casts. This is still slightly odd maybe because it means we hard code them to 0 when they're not used. A "better" structure might be to have some sort of more dynamic structure to avoid this - maybe multiple tuples or a more complex class. However, suspect this is still a small step forward since it allows strict type checking.
michalc
force-pushed
the
feat/final-types-to-enable-strict-type-checking
branch
from
a7015f9 to
2af9797
Compare
Technically a change in the API, but it was a mistake to have these in - they served no purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the internal tuple type to make the uncompressed size and crc_32 non optional ints which makes it possible to pass type checking without any ifs or casts. This is still slightly odd maybe because it means we hard code them to 0 when they're not used. A "better" structure might be to have some sort of more dynamic structure to avoid this - maybe multiple tuples or a more complex class. However, suspect this is still a small step forward since it allows strict type checking.