Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-974 Workbasket data comparison prototype #1002

Merged
merged 19 commits into from
Sep 14, 2023

Conversation

eadpearce
Copy link
Contributor

@eadpearce eadpearce commented Aug 10, 2023

TP2000-974 Workbasket data comparison prototype

Why

  • We want users to be able to compare data in their worksheet to what's in the workbasket without them having to download any pre-published TAP data

What

  • Allows a user to copy and paste data from a spreadsheet into a form and TAP then treats each row as a measure and compares the data to measures in the current workbasket
Screenshot 2023-09-06 at 13 20 20

FireShot Capture 063 - Workbasket 1032 - Summary - Manage Trade Tariffs - localhost

@eadpearce eadpearce force-pushed the TP2000-974-copypasta-prototype branch from 3ee08e0 to bb0f199 Compare September 4, 2023 09:54
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 82.01% and project coverage change: -0.16% ⚠️

Comparison is base (896cf2f) 92.59% compared to head (bb0f199) 92.43%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   92.59%   92.43%   -0.16%     
==========================================
  Files         448      452       +4     
  Lines       32366    32843     +477     
  Branches     2471     2516      +45     
==========================================
+ Hits        29970    30360     +390     
- Misses       1918     2001      +83     
- Partials      478      482       +4     
Files Changed Coverage Δ
commodities/forms.py 100.00% <ø> (ø)
commodities/urls.py 100.00% <ø> (ø)
quotas/forms.py 97.70% <ø> (ø)
workbaskets/urls.py 100.00% <ø> (ø)
workbaskets/views/ui.py 78.83% <37.20%> (-4.46%) ⬇️
workbaskets/util.py 37.86% <38.82%> (+4.53%) ⬆️
workbaskets/forms.py 90.41% <41.66%> (-9.59%) ⬇️
common/jinja2.py 90.56% <66.66%> (-3.06%) ⬇️
common/tests/test_tariffs_api.py 94.64% <81.81%> (ø)
reports/reports/quotas_cannot_be_used.py 86.79% <86.79%> (ø)
... and 26 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eadpearce eadpearce marked this pull request as ready for review September 6, 2023 12:19
@eadpearce eadpearce force-pushed the TP2000-974-copypasta-prototype branch from debc392 to e23c625 Compare September 12, 2023 13:52
Copy link
Contributor

@LaurenMullally LaurenMullally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little blocker comment to stop any accidental merges - need to investigate creates!

@eadpearce eadpearce merged commit 145db4d into master Sep 14, 2023
3 checks passed
@eadpearce eadpearce deleted the TP2000-974-copypasta-prototype branch September 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants