Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1044 Include geo areas with future start dates in dropdown lists #1028

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

dalecannon
Copy link
Contributor

TP2000-1044 Include geo areas with future start dates in dropdown lists

Why

Tariff changes that involve geographical areas with a future start date are unable to be carried out in advance because such geographical areas are unavailable for selection in dropdown lists on geographical area forms (e.g in the create a new measure journey).

What

  • Replaces as_at_today() with as_at_today_and_beyond() for all geographical area forms (create measures journey and quota origins edit journey)
  • Adds test for as_at_today_and_beyond()

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (7024848) 92.65% compared to head (e2e178e) 92.71%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
+ Coverage   92.65%   92.71%   +0.05%     
==========================================
  Files         451      452       +1     
  Lines       32717    33010     +293     
  Branches     2499     2527      +28     
==========================================
+ Hits        30314    30604     +290     
  Misses       1918     1918              
- Partials      485      488       +3     
Files Changed Coverage Δ
geo_areas/forms.py 95.65% <ø> (ø)
quotas/forms.py 97.18% <ø> (-0.53%) ⬇️
common/tests/test_models.py 96.79% <100.00%> (+0.06%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@a-gleeson a-gleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dalecannon dalecannon merged commit 2760a42 into master Sep 19, 2023
3 checks passed
@dalecannon dalecannon deleted the TP2000-1044--geo-area-dropdown-list branch September 19, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants