TP2000-885 Use quota origins and exclusions to populate geo data in create measure journey

[dalecannon]

TP2000-885 Use quota origins and exclusions to populate geo data in create measure journey

Why

There exists a requirement for quotas that geographical data (origins and exclusions) held on a quota order number must match geographical data associated with a measure. To save the user from having to manually select the geographical areas and exclusions, we can take the quota's origins and exclusions to populate automatically the geographical data for measures whenever a quota order number is selected in the create measure journey.

What

• Moves away from cleaned_data["geo_areas_list"] and cleaned_data["geo_area_exclusions"] to combine cleaned_data["geo_areas_and_exclusions"] (list of dictionaries) to accommodate multiple pairs of geo areas and exclusions that can sometimes result from the geo data held on a quota order number

• Sets cleaned_data["geo_areas_and_exclusions"] either with geo data held on order number if one has been selected or with geo area form data in MeasureGeographicalAreaForm.clean()

• Conditionally shows geo areas form or a summary of geo data that will be used to create measures depending if an order number has been selected

• Adds and updates form and view unit tests

• Amends help text on quota order number form page

• Add help text to geo area form/summary page

Example of the summary page of geo areas/exclusions automatically populated from the selected quota order number in place of the geo areas form:

[codecov-commenter]

Codecov Report

Patch coverage: 98.55% and no project coverage change.

Comparison is base (e649a80) 92.71% compared to head (691e771) 92.72%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1032   +/-   ##
=======================================
  Coverage   92.71%   92.72%           
=======================================
  Files         453      453           
  Lines       33046    33085   +39     
  Branches     2527     2538   +11     
=======================================
+ Hits        30639    30678   +39     
+ Misses       1919     1918    -1     
- Partials      488      489    +1     

Files Changed	Coverage Δ
measures/views.py	96.28% <93.75%> (-0.13%)	⬇️
measures/forms.py	95.64% <100.00%> (+0.12%)	⬆️
measures/tests/test_forms.py	99.61% <100.00%> (+<0.01%)	⬆️
measures/tests/test_views.py	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[a-gleeson]

Is this an either or scenario? Where if you add an order number and the geo area's are populated you cannot add more geo area's?

[dalecannon]

Is this an either or scenario? Where if you add an order number and the geo area's are populated you cannot add more geo area's?

That's right. Using an order number replaces selecting geo areas/exclusions.

[a-gleeson]

LGTM! just a couple minor comments

[a-gleeson]

Good catch on the origins! LGTM!