Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1021 Measures tab for additional codes #1033

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

mattjamc
Copy link
Collaborator

TP2000-1021 Measures tab for additional codes

Why

Adding further detail to the additional code details view so users can see active measure information.

What

It allows users to see all associated active measures and updates the action menu so they can view the additional code in find and edit measures.

Previously

image

Update

Includes:

  • measures tab displaying currently active measures linked to that additional code
  • updated action menu to include 'View in find and edit measures'
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up deleting version control tab in next commit and reverting back to inheriting from common as this panel doesn't have the action menu anyway

@mattjamc mattjamc marked this pull request as ready for review September 12, 2023 14:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b19f556) 92.72% compared to head (e9d0e5e) 92.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1033   +/-   ##
=======================================
  Coverage   92.72%   92.73%           
=======================================
  Files         453      453           
  Lines       33085    33112   +27     
  Branches     2538     2538           
=======================================
+ Hits        30677    30705   +28     
+ Misses       1919     1918    -1     
  Partials      489      489           
Files Changed Coverage Δ
additional_codes/tests/test_views.py 100.00% <100.00%> (ø)
additional_codes/views.py 98.60% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@a-gleeson a-gleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@mattjamc mattjamc merged commit db8c0ca into master Sep 20, 2023
3 checks passed
@mattjamc mattjamc deleted the TP2000-1021-measures-tab-for-additional-codes branch September 20, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants