Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-976: Fix flaky test #1035

Merged
merged 2 commits into from
Sep 14, 2023
Merged

TP2000-976: Fix flaky test #1035

merged 2 commits into from
Sep 14, 2023

Conversation

eadpearce
Copy link
Contributor

TP2000-976: Fix flaky test

Why

  • Rerunning tests is annoying

What

  • Ensures validity dates and transactions are explicitly set on test fixtures so that ordering will be the same every time

Copy link
Contributor

@a-gleeson a-gleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sense!

@eadpearce eadpearce merged commit 3fef8f6 into master Sep 14, 2023
@eadpearce eadpearce deleted the TP2000-976-fix-flaky-test branch September 14, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants