Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1048 Add geo area exclusions step to multiple measure edit journey #1039

Merged
merged 15 commits into from
Sep 22, 2023

Conversation

dalecannon
Copy link
Contributor

@dalecannon dalecannon commented Sep 18, 2023

TP2000-1048 Add geo area exclusions step to multiple measure edit journey

Why

Users require the ability to edit the geographical area exclusions of multiple measures.

What

  • Adds MeasuresGeographicalAreaExclusionsForm
  • Adds geographical area exclusions step to MeasureEditWizard
  • Adds view, form unit tests

Screenshot 2023-09-20 at 16 39 37 Screenshot 2023-09-20 at 16 39 57

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: -0.01% ⚠️

Comparison is base (c9fbdbe) 92.76% compared to head (bfbda37) 92.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
- Coverage   92.76%   92.76%   -0.01%     
==========================================
  Files         458      458              
  Lines       33622    33711      +89     
  Branches     2561     2573      +12     
==========================================
+ Hits        31191    31271      +80     
- Misses       1940     1945       +5     
- Partials      491      495       +4     
Files Changed Coverage Δ
measures/views.py 95.28% <83.78%> (-1.01%) ⬇️
measures/conditions.py 100.00% <100.00%> (ø)
measures/constants.py 100.00% <100.00%> (ø)
measures/forms.py 95.76% <100.00%> (+0.08%) ⬆️
measures/tests/test_forms.py 99.62% <100.00%> (+<0.01%) ⬆️
measures/tests/test_views.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalecannon dalecannon marked this pull request as draft September 19, 2023 16:12
@dalecannon dalecannon changed the title TP2000-1048 Add geo area step to multiple measure edit journey TP2000-1048 Add geo area exclusions step to multiple measure edit journey Sep 20, 2023
@dalecannon dalecannon marked this pull request as ready for review September 20, 2023 15:46
measures/constants.py Outdated Show resolved Hide resolved
measures/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@a-gleeson a-gleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple queries but other than that LGTM!

@dalecannon dalecannon merged commit 3c75451 into master Sep 22, 2023
3 checks passed
@dalecannon dalecannon deleted the TP2000-1048--edit-geo-area-mutliple-measures branch September 22, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants