-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP2000-1048 Add geo area exclusions step to multiple measure edit journey #1039
Merged
dalecannon
merged 15 commits into
master
from
TP2000-1048--edit-geo-area-mutliple-measures
Sep 22, 2023
Merged
TP2000-1048 Add geo area exclusions step to multiple measure edit journey #1039
dalecannon
merged 15 commits into
master
from
TP2000-1048--edit-geo-area-mutliple-measures
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
- Coverage 92.76% 92.76% -0.01%
==========================================
Files 458 458
Lines 33622 33711 +89
Branches 2561 2573 +12
==========================================
+ Hits 31191 31271 +80
- Misses 1940 1945 +5
- Partials 491 495 +4
☔ View full report in Codecov by Sentry. |
dalecannon
changed the title
TP2000-1048 Add geo area step to multiple measure edit journey
TP2000-1048 Add geo area exclusions step to multiple measure edit journey
Sep 20, 2023
a-gleeson
reviewed
Sep 22, 2023
a-gleeson
reviewed
Sep 22, 2023
a-gleeson
reviewed
Sep 22, 2023
a-gleeson
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple queries but other than that LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1048 Add geo area exclusions step to multiple measure edit journey
Why
Users require the ability to edit the geographical area exclusions of multiple measures.
What
MeasuresGeographicalAreaExclusionsForm
MeasureEditWizard