Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1064 Fix quota origins in create measure journey #1046

Merged

Conversation

dalecannon
Copy link
Contributor

TP2000-1064 Fix quota origins create measure journey

Why

When an order number is selected in the create a measure journey, all of its origins and exclusions are being used in creating measures even if an origin’s validity period has passed.

What

  • Use as_at_today_and_beyond() to include only active and future origins
  • Updates form test to check only active and future origins are included in cleaned_data
  • Fixed page heading on geo area step to reflect if geo areas are to be reviewed or selected

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6833b1b) 92.73% compared to head (6520c84) 92.73%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1046   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files         453      453           
  Lines       33126    33127    +1     
  Branches     2540     2540           
=======================================
+ Hits        30719    30720    +1     
  Misses       1918     1918           
  Partials      489      489           
Files Changed Coverage Δ
measures/forms.py 95.67% <100.00%> (ø)
measures/tests/test_forms.py 99.61% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalecannon dalecannon merged commit 2b33730 into master Sep 26, 2023
3 checks passed
@dalecannon dalecannon deleted the TP2000-1064--fix-quota-origins-create-measure-journey branch September 26, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants