Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1030 Fix footnote autocomplete selection #1048

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

dalecannon
Copy link
Contributor

TP2000-1030 Fix footnotes autocomplete selection

Why

Footnote descriptions that contain line break characters (\r\n) interfere with the autocomplete field, causing some selections to become unselected. This issue was previously seen with commodities (#932).

What

  • Adds \r character to the newLine regex used to clean autocomplete field results

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (fd99858) 92.76% compared to head (b89f28a) 92.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         458      458           
  Lines       33711    33711           
  Branches     2573     2573           
=======================================
  Hits        31271    31271           
  Misses       1945     1945           
  Partials      495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalecannon dalecannon merged commit 48c1eee into master Sep 26, 2023
3 checks passed
@dalecannon dalecannon deleted the TP2000-1030-fix-footnote-autocomplete-selection branch September 26, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants