Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tp2000 1070 address negative action edge case #1055

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

a-gleeson
Copy link
Contributor

@a-gleeson a-gleeson commented Sep 28, 2023

TP2000-1070 Address negative action edge case

Why

There's an edge case condition where a duty should be applied if there is no certificate present. The negative actions in a condition currently block you populating the certificate, price or applicable duty fields. This requires remove from the edit screen to support.

What

  • removed validation on fields certificate, price or applicable duty on the negative action code conditions in the edit measures screen
  • removed condition_string as it is redundant and causing display bugs for single duty values (3.5%) and measures without additional codes.
  • set .current() for conditions_list so it will display changes in the current worbasket when viewing conditions in list displays
image image image

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (038d9ad) 92.74% compared to head (07ae8e4) 92.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1055   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         458      458           
  Lines       33746    33744    -2     
  Branches     2576     2573    -3     
=======================================
  Hits        31297    31297           
+ Misses       1955     1954    -1     
+ Partials      494      493    -1     
Files Coverage Δ
measures/forms.py 95.75% <100.00%> (-0.01%) ⬇️
measures/tests/test_forms.py 99.62% <100.00%> (+<0.01%) ⬆️
measures/tests/test_models.py 100.00% <100.00%> (ø)
measures/tests/test_views.py 100.00% <100.00%> (ø)
measures/validators.py 96.66% <100.00%> (ø)
measures/views.py 95.28% <100.00%> (ø)
measures/models.py 98.42% <0.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-gleeson a-gleeson merged commit 73f5f11 into master Oct 2, 2023
3 checks passed
@a-gleeson a-gleeson deleted the TP2000-1070--address-negative-action-edge-case branch October 2, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants