Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1387 py312 async success page #1305

Merged
merged 30 commits into from
Nov 4, 2024

Conversation

marya-shariq
Copy link
Collaborator

@marya-shariq marya-shariq commented Oct 11, 2024

TP2000-1387 Async success page & measure edit process queue

Why

  • In this PR, we added 'success pages' to the end of the asynchronous and synchronous bulk measure edit routes

  • The synchronous route just has a success page confirming that the user's bulk edit has been completed

  • The asynchronous route has a success page confirming that a task has been scheduled to bulk edit measures

  • We also added in a new Edit measures process queue tab, and made some content changes.

  • Added a new tab to the measures process queue page to show edit tasks in a similar fashion to create tasks

  • Added a H1 to the Tabs page

  • Amended H1's to H2's in the tabs, to be more edit and create specific

  • Changed the naming conventions of some urls to make sure they're edit/create/sync/async specific

What

  • Created new template for synchronous bulk edit measures
  • Reused 'create measures' template for asynchronous bulk edit measures
  • Added 'expected measures count' property to MeasuresBulkEditor class

Beforeee:

image

Afterr!:

image image

Checklist

  • Requires migrations? - NO
  • Requires dependency updates? - NO

@LaurenMullally LaurenMullally marked this pull request as ready for review October 17, 2024 15:08
@LaurenMullally LaurenMullally requested a review from a team as a code owner October 17, 2024 15:08
common/jinja2/common/celery_queues.jinja Outdated Show resolved Hide resolved
measures/jinja2/measures/confirm-edit-multiple.jinja Outdated Show resolved Hide resolved
measures/jinja2/measures/edit-process-queue.jinja Outdated Show resolved Hide resolved
measures/jinja2/measures/edit-process-queue.jinja Outdated Show resolved Hide resolved
measures/views/wizard.py Outdated Show resolved Hide resolved
measures/urls.py Show resolved Hide resolved
@LaurenMullally LaurenMullally merged commit ce8eac5 into master Nov 4, 2024
8 checks passed
@LaurenMullally LaurenMullally deleted the TP2000-1387-py312-async-success-page branch November 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants