-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP2000-1503 Auto end-date measures #1345
Open
mattjamc
wants to merge
18
commits into
master
Choose a base branch
from
TP2000-1503-auto-end-date-measures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+481
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1503 Auto end-date measures
Why
When a commodity is end-dated, all related measures need to be end-dated. Currently tariff managers are doing this manually in the same workbasket and then moving the measure transactions to the top of the workbasket. This PR automates this process.
What
This PR adds functionality to automatically end measures for commodity codes which have been end-dated in a workbasket. A list view first displays all the measures and whether they will be end-dated or deleted (depending on whether they have started or not). Upon submission the task is passed to a Celery worker. Measures are end-dated or deleted and these transactions are automatically moved to the top of the workbasket.
List view
Confirmation page
List view once all measures have been ended