TP2000-1154 Transaction reordering bug #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1154 Transaction reordering bug
Why
There is currently a bug where if you reorder transactions and then delete one, it becomes impossible to add more objects to a workbasket. This is due to TAP basing a composite_key off the order of a transaction which can change when transactions are reordered. If reordered and one is deleted TAP tries to create a transaction with a composite_key that already exists.
What
This PR changes how a composite_key is generated. The composite key previously included workbasket pk, order and partition.
It appears that composite_key serves as an application level unique ID for a transaction. It does not seem to be used anywhere so changing its structure should solve this bug and not cause any issues.
Composite key is now set to the workbasket id and a 12 digit hexadecimal string. A UUID cannot be used as this field is limited to 16 characters. Nonetheless, a 48 bit hash provides more than enough security with millions of transactions needed before the likelihood of a duplicate (see hash table on this page).