TP2000-1577 Correct usage of select_for_update() in packaged workbasket instance methods #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalecannon
force-pushed
the
TP2000-1577--packaging-queue-race-condition
branch
from
d638ca0 to
d1ebd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1577 Correct usage of select_for_update() in packaged workbasket instance methods
Why
There's been a couple occurrences of the packaging queue becoming stuck as a consequence of packaged workbasket positions being duplicated or out-of-sequence following reordering.
What
select_for_update()to ensure rows are lockedTestPackagingQueueRaceConditionstest class that uses concurrent threads to check race conditions have been sufficiently guarded againstLinks to relevant material
See: Django docs: select_for_update()
See: Jupyter notebook exploring the usage of select_for_update()