Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1478: Missing measures check #1359

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eadpearce
Copy link
Contributor

TP2000-1478: Missing measures check

Why

  • To reduce errors in workbaskets by adding a check to ensure every commodity code has at minimum a type 103 measure associated (Most Favoured Nation or MFN)

What

  • Adds new tab layout design for workbasket checks
  • New page where users can run the missing measures check and see results
  • New database models MissingMeasuresCheck and MissingMeasureCommCode added
  • Extra field added to WorkBasket model - missing_measures_check_task_id. Functions the same as rule_check_task_id
  • The check blocks the publishing of the workbasket if it doesn't pass, like the business rules check
  • The check runs asynchronously in a celery task
  • The check can be stopped and re-run

Still to do

  • Add green and red boxes to match latest design and business rules check page

Checklist

  • Requires migrations? Yes
  • Requires dependency updates? No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant