TP2000-1619-Sub-quota-create-volume-bug

[mattjamc]

TP2000-1619-Sub-quota-create-volume-bug

Why

Ivona encountered an error where she could not create new quota associations due to the sub-quota definition having a different volume to other sub-quotas of the same main-quota. Investigation discovered a few bugs with how the QA5 business rule is executed.

What

The following issues and fixes were identified:

• The business rule was only comparing volumes of existing definitions so Ivona's first differing-volume creation didn't matter. It was the second one that triggered that issue. Solved by comparing the newly inputted volume with the existing one
• It was using volume rather than initial volume which is why there was a difference in the first place. Fixed by changing to initial volume
• original_definition.sub_quotas was including deleted associations which is why Ivona deleting it didn't fix the issue. Solved by adding .current() to the queryset
• Removal of QA5 and QA6 checks for the SubQuotaAssociationDefinitionUpdateForm as it does not make sense to do checks in-form which check against other sub-quotas. It would block the user from letting 1 sub-quota differ even if their intention is to update the other ones afterwards.