Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1596 Quotas - small fixes #1365

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

mattjamc
Copy link
Collaborator

@mattjamc mattjamc commented Dec 18, 2024

TP2000-1596 Quotas - small fixes

Why

Issues identified:

  • When viewing the measures tab on a quota order number details view. The user should be able to see newly created measures. This normally involves using the .current method, rather than latest approved transaction.
  • There are 2 cancel buttons on the delete association page and one doesn't work

What

This PR:

  • update the measures tab on quotas to include draft measures (.current()) as well are future measures (.as_at_today_and_beyond())
  • Removes the second cancel button from the association edit page
  • Overrides get_url() for QuotaAssociation objects to ensure the cancel button redirects to the right page (previously it was going nowhere)

@mattjamc mattjamc marked this pull request as ready for review December 19, 2024 10:39
@mattjamc mattjamc requested a review from a team as a code owner December 19, 2024 10:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mattjamc mattjamc merged commit 24585b7 into master Dec 26, 2024
8 checks passed
@mattjamc mattjamc deleted the TP2000-1596-Quota-measures-tab-not-current branch December 26, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants