TP2000-1660: Add staleness checking to missing measures check #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalecannon
reviewed
Jan 30, 2025
Comment on lines
89
to
+91
| {% else %} | ||
|
|
||
|
|
||
| {% if missing_measures_check.hash != workbasket.commodity_measure_changes_hash %} |
There was a problem hiding this comment.
This conditional may get skipped even if the hash has changed if the last check was successful.
There was a problem hiding this comment.
Oh yeah you're right. I'll see if I can rewrite this template to be a bit less confusing
Comment on lines
89
to
+91
| {% else %} | ||
|
|
||
|
|
||
| {% if missing_measures_check.hash != workbasket.commodity_measure_changes_hash %} |
There was a problem hiding this comment.
Might this staleness check be useful as a boolean property?
Comment on lines
+473
to
+477
| changes = [ | ||
| item | ||
| for item in self.tracked_models.all().order_by("pk") | ||
| if isinstance(item, GoodsNomenclature) or isinstance(item, Measure) | ||
| ] |
There was a problem hiding this comment.
The queryset here and in def has_commodities() could be filtered for subclasses:
qs = self.tracked_models.filter(
Q(instance_of=GoodsNomenclature) | Q(instance_of=Measure)
).order_by("pk")There was a problem hiding this comment.
That's much neater thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1660: Add staleness checking to missing measures check
Why
What
Checklist