Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for list_workbaskets to accept multiple workbasket ids. #668

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stuaxo
Copy link
Contributor

@stuaxo stuaxo commented Aug 26, 2022

Split out dump_transactions main method so it can be called from notebooks more conveniently.
Fix for list_workbaskets to accept multiple workbasket ids.
(Note: We should probably make all the commands that accept workbaskets accept comma separated lists of ids!)

Ensure to actually test, I noticed the list_workbaskets change and added but don't have time to double check, the dump_transactions change is basically just eyeballed as don't have time to double check before going, but I think this is probably a better way of using this from notebooks than the current way of grabbing the Command internals, so even if it doesn't work it may be worth making work.

Split out dump_transactions main method so it can be called from notebooks more convieniently.
@codecov-commenter
Copy link

Codecov Report

Merging #668 (f03bc89) into master (2aba9d3) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
+ Coverage   93.36%   93.44%   +0.07%     
==========================================
  Files         324      325       +1     
  Lines       20822    21124     +302     
  Branches     1658     1672      +14     
==========================================
+ Hits        19441    19739     +298     
+ Misses       1067     1063       -4     
- Partials      314      322       +8     
Impacted Files Coverage Δ
workbaskets/session_store.py 85.18% <0.00%> (-11.12%) ⬇️
workbaskets/views/ui.py 72.68% <0.00%> (-6.38%) ⬇️
commodities/forms.py 72.00% <0.00%> (-5.28%) ⬇️
measures/business_rules.py 87.03% <0.00%> (-1.68%) ⬇️
workbaskets/urls.py 100.00% <0.00%> (ø)
common/tests/util.py 89.11% <0.00%> (ø)
common/tests/test_util.py 100.00% <0.00%> (ø)
common/tests/test_views.py 100.00% <0.00%> (ø)
importer/tests/conftest.py 100.00% <0.00%> (ø)
importer/tests/test_views.py 100.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stuaxo stuaxo force-pushed the management-command-changes branch from ed45953 to 3ad256c Compare August 26, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants