Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support config for prompt template and hyper-param #150

Closed
wants to merge 6 commits into from
Closed

Conversation

ft2023
Copy link
Collaborator

@ft2023 ft2023 commented May 30, 2024

Closes #46

πŸ“‘ Description

βœ… Checks

  • [βœ… ] My pull request adheres to the code style of this project
  • [βœ… ] My code requires changes to the documentation
  • I have updated the documentation as required
  • [ βœ…] All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • [βœ… ] Ready for code review

β„Ή Additional Information

@ft2023 ft2023 requested a review from lwaekfjlk May 30, 2024 16:11
Copy link
Member

@lwaekfjlk lwaekfjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still should not include pycache

base_llm: "mistralai/Mixtral-8x7B-Instruct-v0.1"
max_collaborators_num: 3

prompt_template:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe prompt template should be a string not a list? A list of prompt template is a little bit weird for me.

@lwaekfjlk lwaekfjlk changed the title solve #46 support config file and provide a example yaml May 30, 2024
@lwaekfjlk lwaekfjlk changed the title support config file and provide a example yaml support config for prompt template and hyper-param May 30, 2024
Copy link
Member

@lwaekfjlk lwaekfjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. fix pre-commit formatting erro
  2. change prompt template into a single string
  3. make config an intializer in the ResearchAgent

@lwaekfjlk
Copy link
Member

Closes #46

@lwaekfjlk
Copy link
Member

all the changes are included in #199

@lwaekfjlk lwaekfjlk closed this Jun 2, 2024
@lwaekfjlk lwaekfjlk deleted the change/config branch September 8, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ORG]: put different prompting into a config file to run experiments
3 participants