Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/writing process revision solve the retrieval of writing process #179

Closed
wants to merge 11 commits into from

Conversation

ft2023
Copy link
Collaborator

@ft2023 ft2023 commented May 31, 2024

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

β„Ή Additional Information

@ft2023 ft2023 requested a review from lwaekfjlk May 31, 2024 17:17
Copy link
Member

@lwaekfjlk lwaekfjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also do believe there exists some merging errors in that

@@ -21,7 +22,6 @@
read_paper_prompting,
review_paper_prompting,
review_score_prompting,
summarize_ideas_prompting,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example, this line of code should not be deleted. It is included in the updated main branch

.gitignore Outdated Show resolved Hide resolved
research_town/envs/env_paper_rebuttal.py Outdated Show resolved Hide resolved
submissions[agent.profile.name] = paper
self.db.update(cls=ResearchPaperSubmission, conditions={}, updates=submissions)

submissions: Dict[str, PaperProfile] = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the main branch, the submission should be in ResearchPaperSubmission type instead of PaperProfile type.

It makes sense for the rest of the logic change.

Copy link
Member

@lwaekfjlk lwaekfjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a new PR related to changes in assign_roles and environment logic change using match? Thanks

@chengzr01
Copy link
Member

Can you create a new PR related to changes in assign_roles and environment logic change using match? Thanks

Sure! Sorry for the delay in response. I will reorganize the assign_role function in a separate PR.

@lwaekfjlk
Copy link
Member

already supported in agent-base

@lwaekfjlk lwaekfjlk closed this Jun 28, 2024
@lwaekfjlk lwaekfjlk deleted the feature/writing_process_revision branch September 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants