Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild data type #70

Merged
merged 31 commits into from
May 25, 2024
Merged

rebuild data type #70

merged 31 commits into from
May 25, 2024

Conversation

lwaekfjlk
Copy link
Member

@lwaekfjlk lwaekfjlk commented May 23, 2024

Closes #69

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

@chengzr01
Copy link
Member

chengzr01 commented May 25, 2024

All the tests have passed on my end, including mypy and pytest. I think now the code is ready for merge. Since the Pydantic package can only be used for data validation, I have commented all of the code trying to specify an index parameter in Field (Documentation: https://docs.pydantic.dev/dev/api/fields/). Maybe we can use another ORM package to specify the indices of the database in the future.

@lwaekfjlk
Copy link
Member Author

All the tests have passed on my end, including mypy and pytest. Since the Pydantic package can only be used for data validation, I have commented all of the code trying to specify an index parameter in Field (Documentation: https://docs.pydantic.dev/dev/api/fields/). Maybe we need another ORM package to specify the indices of the database in the future.

Oh, yes, definitely. We just commented out those. Sorry I forget about this.

@lwaekfjlk
Copy link
Member Author

@chengzr01 Thanks, let me review and merge this.

@chengzr01
Copy link
Member

All the tests have passed on my end, including mypy and pytest. Since the Pydantic package can only be used for data validation, I have commented all of the code trying to specify an index parameter in Field (Documentation: https://docs.pydantic.dev/dev/api/fields/). Maybe we need another ORM package to specify the indices of the database in the future.

Oh, yes, definitely. We just commented out those. Sorry I forget about this.

No worries!

@chengzr01
Copy link
Member

@chengzr01 Thanks, let me review and merge this.

Sounds great! Also thank you for your great efforts!

@lwaekfjlk
Copy link
Member Author

@timsanders256 part of the submit env needs further modification

@lwaekfjlk lwaekfjlk merged commit 2ed57ce into main May 25, 2024
0 of 12 checks passed
@lwaekfjlk lwaekfjlk deleted the feature/rebuild-data-type branch September 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ORG]: Rebuild data type
2 participants