Skip to content

Conversation

ale5000
Copy link
Contributor

@ale5000 ale5000 commented Oct 1, 2025

Idea is to make more understandable import, it's not obvious how to pass argument from comment, that need to import specific enum, hope it would be helpful for end-users

Idea is to make more understandable import, it's not obvious how to pass argument from comment, that need to import specific enum, hope it would be helpful for end-users
@tansautn
Copy link
Contributor

tansautn commented Oct 1, 2025

image

It's better to understand if we put "Order direction - an Enum value of SortOrder. Exactly equals to Qt.AscendingOrder / Qt.DescendingOrder."

When someone look into IDE's method document, they would put anything that in SortOrder props or Qt.Asc/Qt.Desc or even pure int: 0/1

@ale5000
Copy link
Contributor Author

ale5000 commented Oct 2, 2025

mb, my pr is just suggestion, but i have a bit a trouble figuring it out without looking into code of lib, if there would be example in readme or here would be enough to figure it much faster for end-user i guess

@tansautn
Copy link
Contributor

tansautn commented Oct 2, 2025

mb, my pr is just suggestion, but i have a bit a trouble figuring it out without looking into code of lib, if there would be example in readme or here would be enough to figure it much faster for end-user i guess

Yup, actually this sorting methods 100% rely on internal Qt's sort method.
And then, cuz i were thinking that anyone use this package must familar with Qt, even more than me.
If not, they would use "QTableWidget", cuz it's stick to Qt's docs, tutorials more than this "young package"
So, provide an "beginner" level example to a expert is useless. That was what in mymind when i'm writing README for this project.

But's we always can get better togetther. And project born to make life easier for devs, so if you think it would quickly to understand. Without look in to source code. Just make an edit in README. But cause it's front side of package. It's should be detailed for everyone reading that infomation, should not "+1 line changes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants