Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize license headers in Python files #42

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

pderrenger
Copy link
Member

@pderrenger pderrenger commented Jan 15, 2025

This PR updates all Python file headers to use a standardized license format. 🔄

Changes:

  • 📝 Standardized header: # Ultralytics 🚀 AGPL-3.0 License - https://ultralytics.com/license
  • 🧹 Ensures consistent spacing after headers
  • 🔍 Applies to all Python files except those in venv

Learn more about Ultralytics licensing 📚

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated license headers and made minor code formatting improvements across multiple scraper files in the repository. 🎉

📊 Key Changes

  • Added Ultralytics' AGPL-3.0 license header to beautiful_scraper.py, bing_scraper.py, and clean_images.py files. 📝
  • Standardized string formatting and corrected minor formatting inconsistencies (e.g., spacing and line breaks in bing_scraper.py). 🔧

🎯 Purpose & Impact

  • 🛡️ Legal Clarity: Ensures proper attribution and compliance by explicitly stating the AGPL-3.0 license.
  • 🧹 Code Hygiene: Minor formatting adjustments enhance code readability and maintain consistent standards.
  • 👥 User Impact: No functional changes; users and contributors can continue using the tool seamlessly while benefiting from the clarified licensing.

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops documentation Improvements or additions to documentation labels Jan 15, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @pderrenger, thank you for submitting a ultralytics/google-images-download 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/google-images-download main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. If you're fixing a bug, providing a Minimum Reproducible Example (MRE) to demonstrate the issue would be very helpful! Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@pderrenger pderrenger merged commit 8a84f24 into main Jan 15, 2025
3 checks passed
@pderrenger pderrenger deleted the refactor-20250115140854 branch January 15, 2025 13:14
@UltralyticsAssistant
Copy link
Member

🎉 Your PR has been merged—thank you, @pderrenger, with special kudos to @glenn-jocher for your contributions! 🙌

Your meticulous work updating license headers and polishing code formatting elevates this project not just in clarity but in professionalism. 🛡️🧹 This kind of thoughtful attention to detail ensures a stronger, more unified foundation for all who build upon it.

As Marcus Aurelius once said, "What we do now echoes in eternity." Your contributions today may seem like minor touches, but they ripple far beyond the present, inspiring best practices and fostering trust in the open-source community. 🌟

Amazing work—thank you both! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants