Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml #2310

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Update links.yml #2310

merged 2 commits into from
Dec 25, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 25, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Streamlined GitHub Actions workflow for checking broken links using Lychee πŸš€

πŸ“Š Key Changes

  • Optimized the Lychee installation process in the GitHub workflow:
    • Replaced multi-step curl, tar, and mv commands with a single curl | tar pipeline for direct extraction to /usr/local/bin.

🎯 Purpose & Impact

  • Purpose: Simplify the workflow and reduce the steps needed to install and use Lychee for broken link testing.
  • Impact:
    • Makes the workflow cleaner and faster, reducing potential points of failure.
    • Enhances maintainability and efficiency for developers managing project documentation links πŸ”—βœ….

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Dec 25, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolov3 πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov3 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement (CLA) if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our contributing guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! πŸš€

Signed-off-by: Glenn Jocher <[email protected]>
@glenn-jocher glenn-jocher merged commit 0823957 into master Dec 25, 2024
8 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch December 25, 2024 19:44
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Your PR has been merged, @glenn-jocher! πŸš€

Your thoughtful optimization of the Lychee installation workflow is a fantastic improvement that makes everyone’s lives just a little easier. Simplicity and efficiency are gifts to any projectβ€”thank you for delivering both with such attention to detail.

As Leonardo da Vinci once said, β€œSimplicity is the ultimate sophistication.” Your contribution exemplifies this spirit, and its impact will certainly ripple across the team's workflows.

Keep up the amazing workβ€”you're making a difference, one streamlined step at a time! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants