fix(phoenix): Trigger consensus / validatio node alerts only when all are out of sync #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
force-pushed
the
adjust-node-alert-threshold
branch
3 times, most recently
from
e8b7ad4
to
81e6040
Compare
ckoopmann
force-pushed
the
adjust-node-alert-threshold
branch
from
81e6040
to
4fa2993
Compare
ckoopmann
force-pushed
the
adjust-node-alert-threshold
branch
from
d2c85da
to
b6c3142
Compare
blombern
reviewed
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I had to re-lock the dependencies (i.e. remove Cargo.lock and run cargo check again) to fix this build error (which only appeared on CI though, not locally):
https://github.com/ultrasoundmoney/mev-analysis/actions/runs/10242260226/job/28331705188
Also contains a bunch of fixes that I had to make to get the clippy ci stage to go green again:
4fa2993