Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres backend support #13

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Postgres backend support #13

wants to merge 11 commits into from

Conversation

theromis
Copy link

No description provided.

@thoas
Copy link
Member

thoas commented May 31, 2019

Having a PostgreSQL backend is a good idea but I can’t accept this PR since it relies on not needed dependencies, in this case an ORM is clearly not needed and we should only use standard library which contains everything you need.

The good side is this PR is great and a good idea!

@theromis
Copy link
Author

ok, will try to change it to basic "native" go postgres stuff
I believe we talking about https://github.com/lib/pq may be will send something tonight

@theromis
Copy link
Author

theromis commented Jun 5, 2019

@thoas Started changes for github.com/lib/pq and realized this library doesn't implement reconnect, pooling and a lot of other "tasty" stuff, all this situations we have to implement manually in the code here, seems like switching will just add more problems. What do you think?

@theromis
Copy link
Author

@thoas What do you think about merging this PR?

@thoas
Copy link
Member

thoas commented May 28, 2020

it needs to be refactored first with this architecture to avoid embed an unnecessary dependency (go-pg/pg).

@theromis
Copy link
Author

@thoas what do you want to see there instead of go-pg/pg?

@thoas
Copy link
Member

thoas commented May 29, 2020

@theromis I don't want anything instead of go-pg/pg, we just need to isolate backends to avoid unnecessary dependency. For example, if I only use the redis backend I don't want the others dependencies.

@theromis
Copy link
Author

@thoas https://github.com/lib/pq is this one fine?
If so https://github.com/go-pg/pg same extra library as lib/pq if we not using go-pg/pg/orm it not adding this dependency, and in this case they equal (only one reqest uses it, can replace by actual SQL query). If check https://github.com/go-pg/pg/blob/master/go.mod there is no dependency to this lib/pq, go-pg implements row pg protocol so they are equal, just can't see any benefits of replacing one by another.

@theromis
Copy link
Author

theromis commented Jun 9, 2020

@thoas will go-pg/orm removal work for you or you prefer to replace go-pg by lib/pq completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants