-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres backend support #13
base: master
Are you sure you want to change the base?
Conversation
Having a PostgreSQL backend is a good idea but I can’t accept this PR since it relies on not needed dependencies, in this case an ORM is clearly not needed and we should only use standard library which contains everything you need. The good side is this PR is great and a good idea! |
ok, will try to change it to basic "native" go postgres stuff |
@thoas Started changes for github.com/lib/pq and realized this library doesn't implement reconnect, pooling and a lot of other "tasty" stuff, all this situations we have to implement manually in the code here, seems like switching will just add more problems. What do you think? |
@thoas What do you think about merging this PR? |
it needs to be refactored first with this architecture to avoid embed an unnecessary dependency ( |
@thoas what do you want to see there instead of |
@theromis I don't want anything instead of |
@thoas https://github.com/lib/pq is this one fine? |
@thoas will |
No description provided.