Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LTO into its own "release-lto" profile #207

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

ulyssa
Copy link
Owner

@ulyssa ulyssa commented Feb 29, 2024

The AUR iamb-git package seems to be broken right now due to some kind of weirdness with the LTO. A user reported in #iamb-users:0x.badd.cafe that they get the following:

          /usr/bin/ld: /home/rek2/.cache/paru/clone/iamb-git/src/iamb/target/release/deps/iamb-dee5b80dcda0a0a7: hidden symbol `GFp_ia32cap_P' isn't defined
          /usr/bin/ld: final link failed: bad value
          collect2: error: ld returned 1 exit status
          
  = note: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)

error: could not compile `iamb` (bin "iamb") due to 1 previous error
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'iamb-git-0.1.e98d58a-1': 
error: packages failed to build: iamb-git-0.1.e98d58a-1

This seems to be the same issue seen in briansmith/ring#1444. It sounds like certain environments result in a mix of GCC and Clang/LLVM being used while building resulting, causing the issue. I'm going to move LTO into its own non-default profile so that people won't hit this. For folks who want smaller binaries (LTO shaves off ~10mb, so I plan to continue using it for the binaries on the releases page), you can build with:

cargo build --profile release-lto

@ulyssa ulyssa enabled auto-merge (squash) February 29, 2024 06:17
@ulyssa ulyssa merged commit aa878f7 into main Feb 29, 2024
4 checks passed
@ulyssa ulyssa deleted the release-lto-profile branch February 29, 2024 06:31
@ulyssa ulyssa added this to the v0.0.9 milestone Feb 29, 2024
@ulyssa ulyssa mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant