Retry suffix of unmapped key sequences #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
force-pushed
the
unmapped-sequences
branch
from
0bab670 to
fb0c62c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an input sequence is unmapped,
ModeKeys::unmappedgets called on just the last key in the sequence. This isn't the right behaviour, and makes it so that doing the common Insert mode mapping of "jj" or "jk" can't work right, since typing an unmapped sequence like "jo" will only type the "o" character. Instead, when a sequence is unmapped,ModeKeys::unmappedshould be called on the first character, and then the rest of the sequence should be retries. That way, if "jk" is mapped to<Esc>, typing "jjk" will type "j" and then go to Normal mode.