Skip to content

feat: make website table rows clickable #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −2
Open

feat: make website table rows clickable #3670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/app/(main)/settings/websites/WebsitesTable.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
.row {
color: inherit;
display: flex;
align-items: center;
width: 100%;
height: 100%;
}

.row:visited {
color: inherit;
}
Comment on lines +1 to +11
Copy link
Contributor

@greptile-apps greptile-apps bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing hover state and text decoration for links. Without visual feedback, users won't know the cells are clickable.

Suggested change
.row {
color: inherit;
display: flex;
align-items: center;
width: 100%;
height: 100%;
}
.row:visited {
color: inherit;
}
.row {
color: inherit;
display: flex;
align-items: center;
width: 100%;
height: 100%;
text-decoration: none;
}
.row:hover {
text-decoration: underline;
}
.row:visited {
color: inherit;
}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/app/(main)/settings/websites/WebsitesTable.module.css
Line: 1:11

Comment:
**style:** Missing hover state and text decoration for links. Without visual feedback, users won't know the cells are clickable.

```suggestion
.row {
  color: inherit;
  display: flex;
  align-items: center;
  width: 100%;
  height: 100%;
  text-decoration: none;
}

.row:hover {
  text-decoration: underline;
}

.row:visited {
  color: inherit;
}
```

How can I resolve this? If you propose a fix, please make it concise.

26 changes: 24 additions & 2 deletions src/app/(main)/settings/websites/WebsitesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { ReactNode } from 'react';
import { Text, Icon, Icons, GridTable, GridColumn } from 'react-basics';
import { useMessages, useTeamUrl } from '@/components/hooks';
import LinkButton from '@/components/common/LinkButton';
import Link from 'next/link';
import styles from './WebsitesTable.module.css';

export interface WebsitesTableProps {
data: any[];
Expand All @@ -28,8 +30,28 @@ export function WebsitesTable({

return (
<GridTable data={data}>
<GridColumn name="name" label={formatMessage(labels.name)} />
<GridColumn name="domain" label={formatMessage(labels.domain)} />
<GridColumn name="name" label={formatMessage(labels.name)}>
{row =>
allowView ? (
<Link href={renderTeamUrl(`/websites/${row.id}`)} className={styles.row}>
{row.name}
</Link>
) : (
row.name
)
}
</GridColumn>
<GridColumn name="domain" label={formatMessage(labels.domain)}>
{row =>
allowView ? (
<Link href={renderTeamUrl(`/websites/${row.id}`)} className={styles.row}>
{row.domain}
</Link>
) : (
row.domain
)
}
</GridColumn>
{showActions && (
<GridColumn name="action" label=" " alignment="end">
{row => {
Expand Down