Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: attempt to fix CI tests related to /hot/ #2294

Closed
wants to merge 1 commit into from
Closed

chore: attempt to fix CI tests related to /hot/ #2294

wants to merge 1 commit into from

Conversation

davidbgk
Copy link
Contributor

No description provided.

@davidbgk
Copy link
Contributor Author

We need to decide first if we want to target the /hot/ theme AND if we want to keep the .fr or switch to .org.

@yohanboniface
Copy link
Member

In fact we don't really care about the used, what we should try to do is to fulfill the request with a dump image (or it can even be a path to a local image), so we do not depend on the network anymore. We only want to check that the import has changed the background, after all.

@yohanboniface
Copy link
Member

fixed in #2317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbgk @yohanboniface