fix: Avoid map-panning on mobile using two fingers navigation #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fttriquet
force-pushed
the
fix-948-map-panning-with-two-fingers
branch
from
ce96615 to
13cc938
Compare
If scrollWheelZoom option is false we deactivate leaflet dragging options only on mobile
fttriquet
force-pushed
the
fix-948-map-panning-with-two-fingers
branch
from
13cc938 to
acbdfda
Compare
|
Thanks! I'm not sure to understand: while in mobile and scrollWheelZoom if off, this will disabled dragging the map with one finger, but it will still be possible with two fingers ? |
|
I guess answer is no (for two fingers scrolling), but let's go like this and see how it goes! |
yohanboniface
added a commit
that referenced
this pull request
Dec 6, 2024
… is false Changing map options at this stage is too late. cf #2340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If scrollWheelZoom option is false we deactivate leaflet dragging options only on mobile